Add ASCII fast path from rust-lang - #20
Merged
Merged
Conversation
See rust-lang/rust's `src/librustc_lexer/src/lib.rs` Idea came from unicode-rs#13
Author
|
Used #21 to verify the performance impact |
Contributor
|
If rustc contains a copy of this code, could efforts be unified? Perhaps with a crate in a new repo in the |
Author
|
@SimonSapin if I'm reading librustc_lexer, it does pull in this crate. It just added a ascii fast path on top of it. Once librustc_lexer upgrades to a new release of this crate, the fast path will become redundant and could be removed. |
Contributor
|
Ah I see, thanks! |
Author
|
@Manishearth whats the release process for this crate? I'm wondering when I could take advantage of this PR. |
Member
|
@epage make a PR with a new version, I'll merge and publish |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See rust-lang/rust's
src/librustc_lexer/src/lib.rsIdea came from #13