-
Notifications
You must be signed in to change notification settings - Fork 823
Unicode text #21661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Unicode text #21661
Conversation
|
π€ Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21661/docs/index.html |
| <Content Include="buildTransitive/*.*"> | ||
| <Pack>true</Pack> | ||
| <PackagePath>buildTransitive</PackagePath> | ||
| </Content> | ||
| <Content Include="icu/unoicu/unoicu.a"> | ||
| <Pack>true</Pack> | ||
| <PackagePath>buildTransitive</PackagePath> | ||
| </Content> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is likely going to duplicate the assets, some coming from uno.icu-wasm, and others from the runtime.browser package. In the final app, those assets should be integrated automatically by the buildTransitive that comes from uno.isu-wasm. (same for the other targets)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this was moved to uno.icu-wasm but I forgot to remove them here.
|
|
|
π€ Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21661/docs/index.html |
|
π€ Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21661/wasm-skia-net9/index.html |
|
|
GitHub Issue: closes #
PR Type:
What is the current behavior? π€
What is the new behavior? π
PR Checklist β
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information βΉοΈ