fix: Storyboard Completed event not firing for dependent animations without EnableDependentAnimation #21711
+100
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storyboard animations targeting dependent properties (Height, Width, Margin, etc.) without
EnableDependentAnimation=truewould never fire theirCompletedevent, breaking animation chains and causing applications to hang waiting for completion.Root Cause
When a dependent animation was skipped, the
Play()method returned early without triggering any completion logic:Changes
Completedfires for skipped dependent animations and doesn't fire when explicitly stoppedBehavior
The animation still doesn't run (existing behavior), but completion handlers now execute as in WinUI3.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
aka.mscurl -I -sSL --retry 5 --retry-delay 2 --connect-timeout 15 REDACTED(dns block)crl.godaddy.comdotnet restore Uno.UI/Uno.UI.Tests.csproj(dns block)ocsp.godaddy.comdotnet restore Uno.UI/Uno.UI.Tests.csproj(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.