Skip to content

chore(ci): run release please before other jobs #1846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elibosley wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore(ci): run release please before other jobs #1846

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acf401b
chore(ci): refactor GitHub Actions workflow to streamline release pro…
elibosley Dec 16, 2025
088f239
chore(ci): remove 'release-please' dependency from 'build-plugin-stag…
elibosley Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 20 additions & 23 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,32 @@ concurrency:
cancel-in-progress: ${{ github.event_name == 'pull_request' }}

jobs:
release-please:
name: Release Please
runs-on: ubuntu-latest
if: github.event_name == 'push' && github.ref == 'refs/heads/main'
permissions:
contents: write
pull-requests: write
steps:
- name: Checkout
uses: actions/checkout@v6
with:
fetch-depth: 0

- id: release
uses: googleapis/release-please-action@v4
outputs:
releases_created: ${{ steps.release.outputs.releases_created || 'false' }}
tag_name: ${{ steps.release.outputs.tag_name || '' }}

test-api:
name: Test API
defaults:
run:
working-directory: api
runs-on: ubuntu-latest
needs: release-please
Copy link
Member

@pujitm pujitm Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we gate build-artifacts as well, or will only blocking one of them suffice? if it's a one or the other situation, i'd recommend blocking build-artifacts since the test run takes much longer.

steps:
Comment on lines 40 to 44
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid gating PR tests on release-please

The new needs: release-please on test-api makes all validation jobs depend on a job that only runs on push to main (see the if on lines 18‑21). On pull_request events release-please is skipped, and GitHub Actions skips any job whose dependency is skipped, so PR workflows will no longer run lint/type-check/tests or the plugin staging build at all. That removes CI coverage for incoming changes.

Useful? React with 👍 / 👎.

- name: Checkout repo
uses: actions/checkout@v6
Expand Down Expand Up @@ -164,29 +184,6 @@ jobs:
VITE_CALLBACK_KEY: ${{ secrets.VITE_CALLBACK_KEY }}
UNRAID_BOT_GITHUB_ADMIN_TOKEN: ${{ secrets.UNRAID_BOT_GITHUB_ADMIN_TOKEN }}

release-please:
name: Release Please
runs-on: ubuntu-latest
# Only run on pushes to main AND after tests pass
if: github.event_name == 'push' && github.ref == 'refs/heads/main'
needs:
- test-api
- build-artifacts
permissions:
contents: write
pull-requests: write
steps:
- name: Checkout
uses: actions/checkout@v6
with:
fetch-depth: 0

- id: release
uses: googleapis/release-please-action@v4
outputs:
releases_created: ${{ steps.release.outputs.releases_created || 'false' }}
tag_name: ${{ steps.release.outputs.tag_name || '' }}

build-plugin-staging-pr:
name: Build and Deploy Plugin
needs:
Expand Down
Loading