Skip to content

Conversation

@elibosley
Copy link
Member

@elibosley elibosley commented Dec 15, 2025

Summary by CodeRabbit

  • Chores
    • Removed a legacy static redirect page that is no longer needed.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 15, 2025

Walkthrough

Removed a static HTML redirect page (emhttp/redirect.htm) that previously handled client-side redirects by reading a target query parameter, computing a final URL with optional data preservation, and navigating via window.location.href.

Changes

Cohort / File(s) Summary
Static redirect removal
emhttp/redirect.htm
Deleted static HTML file that performed client-side redirect logic based on query parameters.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Simple file deletion with no logic migration or refactoring concerns
  • No dependencies or side effects appear to be introduced elsewhere in this diff

Poem

🐰 A redirect page goes away, hooray! hooray!
No more client-side hops to delay,
Simplicity wins the day,
The redirect redirects... away! 🎩✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: deleting the redirect.htm file and moving its functionality to an API, which directly matches the file removal documented in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/move-redirect-htm-to-api

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d0e94e4 and 3fce88e.

📒 Files selected for processing (1)
  • emhttp/redirect.htm (0 hunks)
💤 Files with no reviewable changes (1)
  • emhttp/redirect.htm
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Analyze (javascript-typescript)

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

🔧 PR Test Plugin Available

A test plugin has been generated for this PR that includes the modified files.

Version: 2025.12.15.1742
Build: View Workflow Run

📥 Installation Instructions:

Install via Unraid Web UI:

  1. Go to Plugins → Install Plugin
  2. Copy and paste this URL:
https://preview.dl.unraid.net/pr-plugins/pr-2485/webgui-pr-2485.plg
  1. Click Install

Alternative: Direct Download

⚠️ Important Notes:

  • Testing only: This plugin is for testing PR changes
  • Backup included: Original files are automatically backed up
  • Easy removal: Files are restored when plugin is removed
  • Conflicts: Remove this plugin before installing production updates

📝 Modified Files:

Click to expand file list
emhttp/redirect.htm

🔄 To Remove:

Navigate to Plugins → Installed Plugins and remove webgui-pr-2485, or run:

plugin remove webgui-pr-2485

🤖 This comment is automatically generated and will be updated with each new push to this PR.

@ljm42 ljm42 added the 7.3 label Dec 16, 2025
@ljm42
Copy link
Member

ljm42 commented Dec 16, 2025

Moving redirect.htm from the webgui repo to the API repo: https://github.com/unraid/api/blob/main/plugin/source/dynamix.unraid.net/usr/local/emhttp/redirect.htm

@ljm42 ljm42 marked this pull request as ready for review December 16, 2025 19:51
@limetech limetech merged commit 56fcf71 into master Dec 18, 2025
5 checks passed
@limetech limetech deleted the feat/move-redirect-htm-to-api branch December 18, 2025 23:21
@github-actions
Copy link

🧹 PR Test Plugin Cleaned Up

The test plugin and associated files for this PR have been removed from the preview environment.


🤖 This comment is automatically generated when a PR is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants