feat(card-experience): add detail modal with dynamic data lookup by slug#28
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Add detailed card experience data and standardize identifiers with consistent slug field across data files.
Add slug field to types and pass it through CardExperiencePattern to AnimatedModal for dynamic data lookup.
Replace hardcoded demo content with real card details from snoop_information. Reuse ui/modal.tsx instead of custom portal.
upALX
force-pushed
the
feature/information-card
branch
from
474433e to
8da012b
Compare
…akage Card components have CSS transform which creates a new containing block, breaking position: fixed on the modal overlay. Portal to document.body to ensure viewport-relative positioning.
… CTA Remove separate 'See more' link and consolidate into the modal trigger, styled as a link variant.
The see-more link has been replaced by the modal trigger, so the prop and its passing are no longer needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
snoop-information.jsonwith detailed card data (highlights, tech stack, images, detailed description) for each experience entryAnimatedModalnow uses the existingui/modal.tsxcomponent and renders real data instead of hardcoded travel demo contentcards-timeline.jsonnow use aslugfield to look up their detailed information fromsnoop-information.jsonChanges
src/app/mapper/snoop-information.jsonsrc/app/mapper/cards-timeline.jsonid/uuidwith consistentslugfieldsrc/app/mapper/index.tssnoop_informationexportsrc/components/patterns/modal-pattern.tsxui/modal.tsx, acceptslugprop, render dynamic datasrc/components/patterns/card-experience-pattern.tsxslugtoAnimatedModalsrc/components/types/card-experience-pattern-types.tsslugpropsrc/app/pages/about/page.tsxslugtoCardExperiencePattern; removed unused import