Repository navigation
Reject the iOS-only push authorization calls on Android - #783
Merged
Merged
Conversation
Both methods had empty bodies, so the promise was never settled and a caller awaiting one on Android waited forever, with no error and no timeout. They now reject. The two remaining iOS-only stubs in this file return no promise, so an empty body there settles nothing and is left as it is. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
crow
approved these changes
Oct 21, 2026
khmMouna
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Make
pushIosGetAuthorizedNotificationSettingsandpushIosGetAuthorizedNotificationStatusreject on Android instead of doingnothing.
Why are these changes necessary?
Both had empty bodies, so the promise was never settled. An app that awaits
either of them on Android waits forever — no value, no error, no timeout — and
anything sequenced behind that await never runs.
How did you verify these changes?
Called
Airship.push.iOS.getAuthorizedNotificationStatus()from the exampleapp on an Android emulator, with a 20 second watchdog on the promise.
P57 callingthenP57 STILL PENDING after 20s, nothing further.P57 REJECTED java.lang.IllegalStateException: Not supported on Android, 13 ms after the call.Anything else a reviewer should know?
The two other iOS-only stubs in this file,
pushIosOverridePresentationOptionsand
pushIosIsOverridePresentationOptionsEnabled, take no promise, so an emptybody there leaves nothing unsettled and they are unchanged.
🤖 Generated with Claude Code