Repository navigation
Make lint runnable on a clean install and clear the backlog - #786
Merged
Merged
Conversation
@react-native/eslint-config depends on eslint-plugin-ft-flow, npm nests it under that package, and FlatCompat resolves plugins from the project root, so eslint aborted before linting anything. Reproduced from a clean npm ci against the committed lockfile: the plugin is present only at node_modules/@react-native/eslint-config/node_modules. Adding it as a direct devDependency hoists it. The preset carries 2.0.3 and this pins ^3.0.11; the preset's rules resolve against 3.x with no rule-definition errors. That left 404 problems. --fix cleared 356, and the rest were unused catch bindings and an unused prop, fixed here. Two of the catch blocks do use the error, so they keep their binding. 32 warnings remain and do not fail the run. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Ulrico972
approved these changes
Oct 26, 2026
Apekka
approved these changes
Oct 28, 2026
crow
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Add
eslint-plugin-ft-flowas a direct devDependency so lint can start, thenclear the backlog it had never been able to report.
Why are these changes necessary?
@react-native/eslint-configdepends oneslint-plugin-ft-flow, npm nests itunder that package, and
FlatCompatresolves plugins from the project root. Soeslint aborted before linting anything, and the lint script has never run.
I reproduced it from a clean
npm ciagainst the committed lockfile: theplugin is installed only at
node_modules/@react-native/eslint-config/node_modules/eslint-plugin-ft-flow,and
npm run lintexits with "the plugin isn't installed correctly".How did you verify these changes?
From the same clean install:
npm run lintnow completes with 0 errors andexits 0. 32 warnings remain — mostly inline styles and unstable nested
components — and do not fail the run.
Anything else a reviewer should know?
Most of the diff is
--fixreformatting; it cleared 356 of the 404 problems.The hand-written part is the unused catch bindings and one unused prop.
Two of the
catch (error)blocks do use the error, so they keep their binding.Lint was happy either way — typecheck is what caught it.
The preset carries ft-flow 2.0.3 and this pins
^3.0.11. The preset's rulesresolve against 3.x with no rule-definition errors.
🤖 Generated with Claude Code