Open
Conversation
Update naming to be more standard. Going from `dateline_str` to `date` caused existing code to treat this string as a date variable so some date formatting code was also needed. Updated README Added comment to events template since it has a `.date` but the template isn't currently being used.
Remove extra line feed.
drew-usds
approved these changes
Feb 1, 2024
Contributor
drew-usds
left a comment
drew-usds
left a comment
There was a problem hiding this comment.
LGTM!
Ran locally and all date and readtimes show up a-ok.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename recently added Frontmatter variables
Update naming to be more standard.
dateline_strtodatecaused existing code to treat this string as a date variable so some date formatting code was also needed..datebut the template isn't currently being used.