feat: environment config changed to tab #3370
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
@helloanoop how's it going with this change? i'm looking to work on this issue #3772, and might be dependent on your change to be merged first. 😄 |
|
@hrehovam how's it going on this change? |
4 tasks
helloanoop
requested review from
helloanoop,
lohit-bruno,
maintainer-bruno and
naman-bruno
as code owners
# Conflicts: # packages/bruno-app/src/components/Environments/EnvironmentSelector/index.js # packages/bruno-app/src/components/Environments/EnvironmentSettings/index.js # packages/bruno-app/src/components/RequestTabPanel/index.js # packages/bruno-app/src/components/RequestTabs/RequestTab/index.js # packages/bruno-app/src/providers/ReduxStore/slices/tabs.js
Author
|
Hi, since I was busy I had no time to fix the conflicts. Conflicts are now fixed and this change is ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat: #1072 #1040
As suggested in issues above, I changed Environment config from Modal to Tab. It can help with unwanted miss-clicks out of modal which cause loss of configuration. New tab is opened after clicking on Configure button as it was before. Current behavior can be seen on the screen below.
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.