Skip to content

Conversation

@sanish-bruno
Copy link
Collaborator

Description

This is the test cases for grpc request as a followup to #5793

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

@sid-bruno
Copy link
Collaborator

nitpick: but can we move the repeated locators to the tests/utils/page/locators.ts file and use that instead, easier to replace the locator if we change test id or classes or anything that we are using to locate. Not mandatory, mostly a suggestion

@sanish-bruno
Copy link
Collaborator Author

nitpick: but can we move the repeated locators to the tests/utils/page/locators.ts file and use that instead, easier to replace the locator if we change test id or classes or anything that we are using to locate. Not mandatory, mostly a suggestion

sure, i will keep this in mind, will make necessary changes

feat: add common selectors to locator.ts

fix: add dataTestId prop

update locator
@sanish-bruno sanish-bruno force-pushed the add/grpc-make-request-tests branch from 7b184d4 to 1d820f3 Compare November 7, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants