Skip to content

Conversation

@abhishek-bruno
Copy link
Member

@abhishek-bruno abhishek-bruno commented Nov 7, 2025

Description

  • Enhanced the SingleLineEditor component by adding a data-testid attribute for improved testing.
  • Updated TagList component to include a data-testid for the tag input and modified the tag removal button for better accessibility.
  • Refactored various test cases to replace right-click actions with hover interactions for context menus, improving reliability across different environments.
  • Added wait times in tests to ensure elements are fully rendered before interactions, enhancing test stability.
  • Cleaned up and optimized test code for better readability and maintainability.

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

@abhishek-bruno abhishek-bruno force-pushed the refactor/playwright-flaky-tests branch from 4b24430 to bc2aa5d Compare November 7, 2025 16:28
cursor: default;
&:hover {
&:has(.tag-remove:hover) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhishek-bruno Hover styling should be just in and around the .tag-remove icon similar to the request tab close icon. Let's fix this in a followup PR.

@bijin-bruno bijin-bruno merged commit a186df3 into usebruno:main Nov 7, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants