Repository navigation
feat: save selected text from a nearby Memos button - #21
Open
ObsidianArch02 wants to merge 2 commits into
Open
ObsidianArch02 wants to merge 2 commits into
ObsidianArch02 wants to merge 2 commits into
Conversation
Preserve selected content and reuse the context menu save flow. Refs: usememos#19
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #19
Verification
pnpm lintpnpm test: 404 tests passed with Node 22, matching upstream CI.pnpm buildpnpm audit --prodnode scripts/package.mjs all: packages built. Firefox validation reported zero errors and seven bundled-code warnings.The existing Space submenu keyboard focus test at
src/popup/__tests__/App.dom.test.tsx:421failed intermittently with Node 26. The same failure also reproduced on unchanged upstream code. The final Node 22 suite passed.Firefox packages were built. Interactive Firefox behavior still needs verification.
Generated by Codex with GPT-6