Fix terminal detection permission issue (#179) #533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
again, please stop with the AI generated comment 0 |
Contributor
|
I don't know if you have seen it: |
cakebaker
reviewed
Oct 11, 2025
naoNao89
added a commit
to naoNao89/procps
that referenced
this pull request
Nov 2, 2025
Merge latest changes from origin/main which added euid check to basic_collector for better process filtering. Kept mutable borrow for tty() method as required by PR uutils#533.
naoNao89
added a commit
to naoNao89/procps
that referenced
this pull request
Nov 2, 2025
Remove unnecessary condition check in the match arm for virtual console terminals. Both branches returned the same value, so the condition was redundant. Addresses review feedback from PR uutils#533.
- Read tty_nr from /proc/PID/stat (field 7) which is world-readable
- Add TryFrom<u64> implementation to decode tty_nr device numbers
- Fix Display impl bug that had wrong device name mappings:
* Tty now maps to /dev/tty{id} (was /dev/pts/{id})
* TtyS now maps to /dev/ttyS{id} (was /dev/tty{id})
* Pts now maps to /dev/pts/{id} (was /dev/ttyS{id})
- Update tty() method to use stat file first, fall back to fd scanning
- Update all callers to use mutable borrow for tty() method
- Simplify tty_nr decoding for major device 4 (review feedback)
- Fix implicit clone warning in process_matcher.rs
This fixes issue uutils#179 where pgrep -t would fail when run as a normal user
because /proc/PID/fd is only readable by the process owner.
naoNao89
force-pushed
the
fix-tty-detection-issue-179
branch
from
e950008 to
0edd3e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #179 where pgrep -t would fail when run as a normal user because /proc/PID/fd is only readable by the process owner.