fix: always set overflow: auto on dialog content part #10574
+0
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DiegoCardoso
approved these changes
Dec 4, 2025
Member
|
The reason for conditionally setting overflow is that focus outlines and other visual effects outside a component that’s on the edge of the content area would be visible if when scrolling is not needed. 
vs 
|
Member
|
That’s arguably a minor issue, and maybe something that the app developer might consider fixing by applying a small padding on the content layout. |
jouni
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes vaadin/flow-components#8321
Previously in #9903 the logic was changed to set
overflowon dialog resizer container resize and only applyoverflow: autoifoverflowattribute is set, which is different from the V24 version.However, in case of expanding
vaadin-detailscomponent there is no change in.resizer-containerand therefore the content overflows. This PR changes the CSS to always applyoverflow: autowhich handles such cases correctly.Type of change