Repository navigation
Conversation
FanWu-ai
marked this pull request as ready for review
October 8, 2026 21:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isMailtoURIrejects addresses on percent-encoded internationalized domains. For example, the URI from RFC 6068 §6.3 currently returnsfalse:Decode each recipient once after parsing the URI delimiters, then pass the decoded address to
isEmail. This also makes malformed percent-encoding returnfalseand applies existing email options to the actual recipient address. Reject decoded C0 and DEL controls before email validation, as required by RFC 6068 §2. Literal and encoded plus signs, escaped percent signs, and printable quoted local parts remain supported.The regression tests cover direct recipients, cc/bcc, internationalized domains, encoded local parts, malformed encoding, and existing email options. No public API or option changes.
Validation on Node.js 24.19.0:
npm test: 323 passing.npm test: 327 passing, including all builds, minification, ESLint and coverage.git diff --checkpassed.AI assistance was used to prepare the implementation and regression tests.
Checklist