Repository navigation
Conversation
FanWu-ai
marked this pull request as ready for review
October 9, 2026 21:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isMACAddress('01:23:45:67:89:ab', Object.freeze({ eui: 48 }))throws instead of returning a boolean. The function writes its normalized EUI value back into the caller's options, even when the supplied value is already a string. It also changes a mutable options object's numericeuito a string.Normalize EUI into a local variable and use it for the existing comparisons. Validation rules remain unchanged. Regression coverage checks frozen numeric/string EUI-48 and EUI-64 options, the
no_separatorsand legacyno_colonsoptions, valid/invalid addresses and preservation of a mutable options object.Validation on Linux / Node 24.19.0:
npm test: 323 passing.npm test: 325 passing, including all builds, minification, ESLint and coverage.git diff --checkpasses.Statement, function and line coverage remain 100%. Branch coverage changes from 96.59% (1697/1757) to 96.57% (1689/1749), because eight covered branches disappear when repeated optional chaining is replaced by the local variable; the number of uncovered branches stays 60. The remote Node-version CI matrix has not been run locally.
AI assistance was used to prepare the implementation and regression tests.
Checklist