Repository navigation
Conversation
FanWu-ai
marked this pull request as ready for review
October 10, 2026 21:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isLocaleaccepts malformed tags such asde-CH-190-anden-1--a. The digit-leading variant branch uses[A-Z-a-z0-9], which includes a literal hyphen, allowing empty or truncated subtags to pass.Remove the unintended hyphen from that character class. RFC 5646 §2.1 defines this variant form as a digit followed by three alphanumeric characters: https://www.rfc-editor.org/rfc/rfc5646.html#section-2.1
The regression keeps valid digit-leading variants, multiple variants, and the library's existing underscore delimiter support covered.
Validation (Node.js 24.19.0):
isLocale("de-CH-190-") passed but should have failed.npm test: 323 passing.npm test: 324 passing; all generated builds and ESLint passed; statements, lines, and functions remain at 100% coverage.git diff --checkpassed.Tests ran with HOME and npm cache redirected to writable temporary directories. No checks were disabled. No generated distributions are included.
Prepared with OpenAI Codex. The reproduction and local checks above were executed in the development environment.
Checklist