Repository navigation
Conversation
Restore the scheme case-insensitivity lost by the prefix guard in validatorjs#1992. Add v1/v2, parameter-order and invalid-prefix regression cases.
FanWu-ai
marked this pull request as ready for review
October 11, 2026 18:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The component regex accepts case-insensitive magnet schemes, but the prefix check introduced in #1992 rejects uppercase and mixed-case schemes before reaching it. Restore the previous behavior with an anchored case-insensitive prefix check, consistent with RFC 3986 §3.1.
The regression covers direct/later exact-topic parameters, BitTorrent v1/v2, and malformed-prefix controls. Query data and existing component validation are unchanged.
Validation on Node 24.19.0:
npm test: 323 passing.npm test: 324 passing; all builds/minification, ESLint and coverage passed.git diff --checkpassed.Checklist:
Prepared with OpenAI Codex assistance.