user provisioned custom nodes downloaded into the correct target folder - #6
Closed
nprabhakar wants to merge 1 commit into
Closed
nprabhakar wants to merge 1 commit into
nprabhakar wants to merge 1 commit into
Conversation
…getting activated in the default provisioning script, the user-configured, custom nodes were getting downloaded into the parent folder, and not getting activated
Collaborator
|
Thank you — and apologies for the long silence. Your diagnosis was correct and the bug was still on Fixed in #236, which credits you as co-author and extends the same fix to |
robballantyne
added a commit
that referenced
this pull request
Aug 6, 2026
…e it (#236) COMFYUI_DIR is ${WORKSPACE}/ComfyUI with no trailing slash, so "${COMFYUI_DIR}custom_nodes/${dir}" resolved to /workspace/ComfyUIcustom_nodes/ — a sibling directory ComfyUI never scans. Every custom node a user listed in NODES was cloned somewhere it could not be loaded from, and because the [[ -d $path ]] guard never matched, each provisioning run re-cloned the lot. Remaining in default.sh, flux.sh and hunyuan3d.sh; the same line was already correct in lora.sh, image-tools.sh, ltx-video.sh and text_to_video_wan.sh, which is why it survived this long. Reported independently in #5 (amgad-naiem) and #6 (nprabhakar) in March 2025. Co-authored-by: amgad-naiem <amgad.naiem@gmail.com> Co-authored-by: nprabhakar <nprabhakar@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in the default provisioning script, the user-configured, custom nodes were getting downloaded into the parent folder, and not getting activated