fix(storage): send webhook HTTP failures to the recovery queue - #204
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generic
storage.webhookbackend logs HTTP 4xx/5xx responses and returns success, so those failures bypass the storage recovery queue introduced by #197/#202. Raise HTTP errors after recording the response metric, and bound each request with a configurabletimeout(default 30 seconds).Failed writes now reach the existing per-backend DLQ without repeating processing links. Arbitrary POST receivers are not automatically retried because their idempotency contracts are unknown. The recovery runbook explains that replay of multiple webhook URLs can repeat earlier successful deliveries.
Validation: five new regressions failed before the fix and now pass, covering 401/500/503 through the actual conserver DLQ handler and default/custom timeout. All 29 focused storage/recovery tests pass. Independent review found no required blockers. Broader common/conserver suite passed: 283 tests, 2 skipped, using isolated RedisJSON (one existing audioop deprecation warning).
Tracks the remaining webhook-backend coverage gap in CON-714. The shared recovery infrastructure is already deployed, but this backend fix still needs release and deployment.