Initial 1.16.5/Sponge API 8 Functionality (Currently Forge Only)#2
Open
NickImpact wants to merge 1 commit intovectrix-space:devfrom
Open
Initial 1.16.5/Sponge API 8 Functionality (Currently Forge Only)#2NickImpact wants to merge 1 commit intovectrix-space:devfrom
NickImpact wants to merge 1 commit intovectrix-space:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This provides initial 1.16.5/Sponge API 8 compatibility. There are likely some packet mappings to adjust, as well as additional improvements that can be made to the API (such as custom packet type definitions).
At present, this code is only capable of running on Forge. Between SV and SF, there is some mapping incompatibility that will require some additional research to get working with both platforms. Due to environment issues, this was not tremendously tested, and was only verified for bootup success. Ideally, this should move away from ForgeGradle and instead use VanillaGradle, but perhaps there's an additional method we can use to have ForgeGradle mappings work with SV.
Notable differences: