[APO-2194] Raise error on json serialization errors for outputs #3135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NgoHarrison
force-pushed
the
harrison/apo-2194-raise-bytes-error
branch
2 times, most recently
from
61d38b5 to
b6ce6e0
Compare
Comment on lines
575
to
584
| try: | ||
| default_serializer(output) | ||
| except (TypeError, ValueError) as exc: | ||
| raise NodeException( | ||
| message=( | ||
| f"Node {node.__class__.__name__} produced output: " | ||
| f"'{output.name}' that could not be serialized to JSON: {exc}" | ||
| ), | ||
| code=WorkflowErrorCode.INVALID_OUTPUTS, | ||
| ) from exc |
Contributor
There was a problem hiding this comment.
[blocking] I would rather support than add this overhead on every chunk from a node. Should be as easy as updating VellumJsonEncoder I believe
…and remove per-chunk overhead Co-Authored-By: [email protected] <[email protected]>
devin-ai-integration
bot
force-pushed
the
harrison/apo-2194-raise-bytes-error
branch
from
b6ce6e0 to
e5c77de
Compare
…d base64 fallback Co-Authored-By: [email protected] <[email protected]>
dvargas92495
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.