[APO-2321] Make entrypoint node optional in Python SDK serialization #3346

devin-ai-integration · 2025-12-10T06:49:00Z

Summary

Makes the ENTRYPOINT node optional in workflow serialization. When all graph branches originate from triggers (IntegrationTrigger/ScheduleTrigger), no ENTRYPOINT node is created. For triggerless workflows with partial WorkflowMetaDisplay overrides (e.g., only display_data set), the backfill logic in _generate_workflow_meta_display ensures proper entrypoint IDs are generated by merging overrides with defaults.

Also fixes duplicate edge IDs when multiple non-manual triggers target the same node - each trigger edge now gets a unique deterministic ID based on workflow_id|trigger_edge|trigger_id|target_node_id.

This is the Python SDK counterpart to the codegen changes in #3345.

Review & Testing Checklist for Human

Verify edge ID generation change doesn't break existing workflows (snapshot updated for simple_manual_trigger_workflow)
Verify multiple IntegrationTriggers targeting the same node produce unique edge IDs
Verify triggerless workflows with partial WorkflowMetaDisplay overrides (only display_data set) still create ENTRYPOINT nodes with valid IDs
Test end-to-end with codegen PR [APO-2321] Generate graphs without entrypoint node #3345 and run vellum push on workflows with triggers

Test Plan:

Serialize a workflow with two IntegrationTriggers pointing to the same node - verify edges have unique IDs
Serialize a triggerless workflow with WorkflowMetaDisplay(display_data=...) - verify ENTRYPOINT node exists
Serialize an IntegrationTrigger-only workflow - verify NO ENTRYPOINT node, edges use trigger ID

Notes

Edge ID generation now uses deterministic hash for all trigger edges (not just when metadata mapping is missing)
New regression tests: test_partial_workflow_meta_display_override.py, test_two_integration_triggers_same_node_unique_edge_ids

Requested by: @NgoHarrison
Session: https://app.devin.ai/sessions/aae1511f5a8e421bbd799cd1d5b58077

vellum-automation · 2025-12-10T06:49:04Z

@codex review

devin-ai-integration · 2025-12-10T06:49:06Z

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

Address comments on this PR that start with 'DevinAI' or '@devin'.
Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

Disable automatic comment and CI monitoring

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2025-12-10T06:55:17Z

ee/vellum_ee/workflows/display/base.py

 @dataclass
 class WorkflowMetaDisplay:
-    entrypoint_node_id: UUID
-    entrypoint_node_source_handle_id: UUID
-    entrypoint_node_display: NodeDisplayData = Field(default_factory=NodeDisplayData)
+    entrypoint_node_id: Optional[UUID] = None
+    entrypoint_node_source_handle_id: Optional[UUID] = None
+    entrypoint_node_display: Optional[NodeDisplayData] = None


Backfill entrypoint defaults when overrides omit IDs

The entrypoint metadata on WorkflowMetaDisplay is now optional (lines 52‑54), but _generate_workflow_meta_display still copies user overrides verbatim while serialize() only builds an ENTRYPOINT node when both IDs are set (base_workflow_display.py:299‑305). For a triggerless workflow that overrides only the viewport, e.g. workflow_display = WorkflowMetaDisplay(display_data=…), the IDs default to None, the guard skips node creation, and the serialized workflow ends up missing the required ENTRYPOINT node. This newly breaks serialization for workflows without triggers whenever partial overrides are supplied.

Useful? React with 👍 / 👎.

This looks legit

dvargas92495 · 2025-12-15T00:23:02Z

ee/vellum_ee/workflows/display/base.py

 @dataclass
 class WorkflowMetaDisplay:
-    entrypoint_node_id: UUID
-    entrypoint_node_source_handle_id: UUID
-    entrypoint_node_display: NodeDisplayData = Field(default_factory=NodeDisplayData)
+    entrypoint_node_id: Optional[UUID] = None
+    entrypoint_node_source_handle_id: Optional[UUID] = None
+    entrypoint_node_display: Optional[NodeDisplayData] = None


This looks legit

Co-Authored-By: [email protected] <[email protected]>

…y workflows - Backfill entrypoint IDs in _generate_workflow_meta_display when overrides omit them - Skip ENTRYPOINT node when all graph branches are sourced from triggers - Update tests to match new spec for IntegrationTrigger-only workflows Co-Authored-By: [email protected] <[email protected]>

Co-Authored-By: [email protected] <[email protected]>

NgoHarrison · 2025-12-15T15:51:09Z

@codex review

chatgpt-codex-connector

💡 Codex Review

vellum-python-sdks/ee/vellum_ee/workflows/display/workflows/base_workflow_display.py

Lines 499 to 503 in 2f157d9

    
           trigger_edge_dict: Dict[str, Json] = { 
        
               "id": str(stable_edge_id) if stable_edge_id else str(target_entrypoint_display.edge_display.id), 
        
               "source_node_id": str(source_node_id), 
        
               "source_handle_id": str(source_handle_id), 
        
               "target_node_id": str(target_node_display.node_id),

Duplicate IDs for multiple trigger edges without entrypoint node

When all branches are trigger-sourced the ENTRYPOINT node is skipped, but trigger edges still fall back to target_entrypoint_display.edge_display.id when no metadata mapping exists. That edge display ID is generated once per target node (using the workflow display’s entrypoint UUID), so multiple non-manual triggers feeding the same node will serialize distinct edges with identical id values (e.g., two IntegrationTriggers pointing at one process node). Clients typically treat edge IDs as unique keys, so these duplicates can collapse edges or hide triggers whenever metadata.json lacks explicit IDs.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Co-Authored-By: [email protected] <[email protected]>

NgoHarrison · 2025-12-15T16:49:30Z

@codex review

chatgpt-codex-connector · 2025-12-15T17:04:34Z

Codex Review: Didn't find any major issues. Keep it up!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

devin-ai-integration bot assigned NgoHarrison Dec 10, 2025

devin-ai-integration bot requested a review from NgoHarrison December 10, 2025 06:49

chatgpt-codex-connector bot reviewed Dec 10, 2025

View reviewed changes

devin-ai-integration bot force-pushed the devin/1765348829-optional-entrypoint-node branch from 530f9c0 to 6937d60 Compare December 11, 2025 00:12

NgoHarrison approved these changes Dec 12, 2025

View reviewed changes

NgoHarrison requested review from dvargas92495 and vincent0426 December 12, 2025 21:09

dvargas92495 approved these changes Dec 15, 2025

View reviewed changes

devin-ai-integration bot and others added 5 commits December 15, 2025 15:20

[APO-2321] Make entrypoint node optional in Python SDK serialization

17c2c26

Co-Authored-By: [email protected] <[email protected]>

Fix: restore non_trigger_entrypoint_nodes variable for edge generation

f77fa1c

Co-Authored-By: [email protected] <[email protected]>

Fix: rename display_data variables to avoid mypy type inference issues

61106c0

Co-Authored-By: [email protected] <[email protected]>

Add regression test for partial WorkflowMetaDisplay override

6d159a3

Co-Authored-By: [email protected] <[email protected]>

devin-ai-integration bot force-pushed the devin/1765348829-optional-entrypoint-node branch from 2e3aa2f to 6d159a3 Compare December 15, 2025 15:24

Fix mypy type errors in regression test

2f157d9

Co-Authored-By: [email protected] <[email protected]>

NgoHarrison marked this pull request as ready for review December 15, 2025 15:51

chatgpt-codex-connector bot reviewed Dec 15, 2025

View reviewed changes

devin-ai-integration bot and others added 2 commits December 15, 2025 16:41

Fix duplicate edge IDs for multiple triggers targeting same node

ad8cd53

Co-Authored-By: [email protected] <[email protected]>

Update snapshot for simple_manual_trigger_workflow edge ID

3ae8213

Co-Authored-By: [email protected] <[email protected]>

NgoHarrison merged commit 4c09c35 into main Dec 15, 2025
9 checks passed

NgoHarrison deleted the devin/1765348829-optional-entrypoint-node branch December 15, 2025 17:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[APO-2321] Make entrypoint node optional in Python SDK serialization #3346

[APO-2321] Make entrypoint node optional in Python SDK serialization #3346

Uh oh!

devin-ai-integration bot commented Dec 10, 2025 •

edited

Loading

Uh oh!

vellum-automation bot commented Dec 10, 2025

Uh oh!

devin-ai-integration bot commented Dec 10, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Dec 10, 2025

Uh oh!

dvargas92495 Dec 15, 2025

Uh oh!

dvargas92495 Dec 15, 2025

Uh oh!

NgoHarrison commented Dec 15, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

NgoHarrison commented Dec 15, 2025

Uh oh!

chatgpt-codex-connector bot commented Dec 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	trigger_edge_dict: Dict[str, Json] = {
	"id": str(stable_edge_id) if stable_edge_id else str(target_entrypoint_display.edge_display.id),
	"source_node_id": str(source_node_id),
	"source_handle_id": str(source_handle_id),
	"target_node_id": str(target_node_display.node_id),

[APO-2321] Make entrypoint node optional in Python SDK serialization #3346

[APO-2321] Make entrypoint node optional in Python SDK serialization #3346

Uh oh!

Conversation

devin-ai-integration bot commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Review & Testing Checklist for Human

Notes

Uh oh!

vellum-automation bot commented Dec 10, 2025

Uh oh!

devin-ai-integration bot commented Dec 10, 2025

🤖 Devin AI Engineer

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

dvargas92495 Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

dvargas92495 Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

NgoHarrison commented Dec 15, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

NgoHarrison commented Dec 15, 2025

Uh oh!

chatgpt-codex-connector bot commented Dec 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

devin-ai-integration bot commented Dec 10, 2025 •

edited

Loading