[nickgeenfield]

A simple comic reader for the Paper Pro, which reads cbr and cbz comics.

[rmitchellscott]

Before we can merge, please change the package to build from source instead of repackaging the release tarball. We need the binary in Vellum to come from the tagged source.

I tried this locally and it builds from v1.5.2 for aarch64 with no upstream changes, using the same pattern as packages/saver-remarkable/VELBUILD:

source="$pkgname-$pkgver.tar.gz::https://github.com/$upstream_author/FourColour/archive/refs/tags/v$pkgver.tar.gz"
builddir="$srcdir/FourColour-$pkgver"

image="ghcr.io/toltec-dev/rust:v4.0"

build() {
	set -e
	apt-get update
	apt-get install -y --no-install-recommends qt6-base-dev

	. /opt/x-tools/switch-aarch64.sh

	cd "$builddir"/app/backend
	cargo build --release --locked --target "$CARGO_BUILD_TARGET"
	mv target/"$CARGO_BUILD_TARGET"/release/rmcomics-backend "$builddir"/entry
	cp "$HOME"/.cargo/registry/src/*/unrar_sys-*/vendor/unrar/license.txt \
		"$builddir"/LICENSE-UNRAR

	cd "$builddir"/app
	/usr/lib/qt6/libexec/rcc --binary -o "$builddir"/resources.rcc application.qrc
}

package() then needs these changes:

• Install app/manifest.json, resources.rcc, assets/icon.png and entry (mode 755) from the build tree.
• Install LICENSE from the source archive, so the separate LICENSE download can go.
• Install LICENSE-UNRAR next to LICENSE. The binary statically links UnRAR, which has its own license terms, so that file needs to ship with the package. license="MIT" can stay as it is.
• Write SOURCES with $url/archive/refs/tags/v$pkgver.tar.gz. $upstream_author is empty inside package().

Also:

• The purge in postdeinstall should also remove /home/root/.cache/rm-comics, otherwise extracted pages stay on the device.

Please test the source-built package on a Paper Pro before we merge. It's different from your release build in two ways: entry is dynamically linked against glibc and libstdc++ instead of static musl, and resources.rcc is zstd-compressed. I haven't run it on a tablet. Please check that it launches from AppLoad and opens both a .cbz and a .cbr

[nickgeenfield]

Thanks for the review. I've updated the VELBUILD to build from the tagged v1.5.2 source following the saver-remarkable pattern: rust:v4.0 with qt6-base-dev, cargo build in app/backend, rcc for resources.rcc, LICENSE from the archive plus LICENSE-UNRAR, SOURCES set to the tag archive, and the purge now also removes /home/root/.cache/rm-comics. I tested the source-built package on my Paper Pro (3.28): it installs, launches from AppLoad, and opens both .cbz and .cbr files fine.

[rmitchellscott]

/publish-testing

[github-actions]

Packages published to testing repo:

• fourcolour

Install with:

vellum add fourcolour@testing