Fix infinite queue retry loop for cancelled workflow runs #1016
+10
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
410 Gone(completed runs) but not409 Conflict(cancelled/terminal runs)step_retryingevent also returned 409, which was uncaught — causing the queue to retry the message indefinitelyContext
Observed in production: a cancelled workflow run (
wrun_01KH4WFCWWHVRK9331EX49EMQH) triggered 99+ queue retries in ~18 hours with no sign of stopping.