Skip to content

Remove ipin rr switch #3358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Nov 28, 2025
Merged

Remove ipin rr switch #3358

merged 17 commits into from
Nov 28, 2025
+67 −148

Conversation

@amin1377
Copy link
Contributor

@amin1377 amin1377 commented Nov 22, 2025 •
edited
Loading

Removing ipin_rr_switch_id

@github-actions github-actions bot added VPR VPR FPGA Placement & Routing Tool lang-cpp C/C++ code labels Nov 22, 2025
soheilshahrouz
soheilshahrouz reviewed Nov 25, 2025
View reviewed changes
Copy link
Contributor

@soheilshahrouz soheilshahrouz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Amin!

I also suggest adding a test where ipin switch delay is fanin dependent.

@amin1377
Copy link
Contributor Author

amin1377 commented Nov 25, 2025

@soheilshahrouz: I applied the changes you requested. Regarding the test for variable IPIN delays, I already have one for CRR in the CRR PR. As for the default RR graph generator, since it hasn’t been tested before, implementing it will take some time. If you agree, I suggest we handle that in a separate PR.

soheilshahrouz
soheilshahrouz reviewed Nov 25, 2025
View reviewed changes
@soheilshahrouz
Copy link
Contributor

soheilshahrouz commented Nov 25, 2025

@soheilshahrouz: I applied the changes you requested. Regarding the test for variable IPIN delays, I already have one for CRR in the CRR PR. As for the default RR graph generator, since it hasn’t been tested before, implementing it will take some time. If you agree, I suggest we handle that in a separate PR.

I meant a test where the architecture file uses a switch with fanin dependent delay. I guess CRR overrides the IPIN switch specified in the architecture file.

@amin1377 amin1377 merged commit 3a6bccc into master Nov 28, 2025
30 checks passed
@amin1377 amin1377 deleted the remove_ipin_rr_switch_id branch November 28, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soheilshahrouz soheilshahrouz soheilshahrouz left review comments

@AmirhosseinPoolad AmirhosseinPoolad Awaiting requested review from AmirhosseinPoolad

Assignees

No one assigned

Labels

lang-cpp C/C++ code VPR VPR FPGA Placement & Routing Tool

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amin1377 @soheilshahrouz