-
Notifications
You must be signed in to change notification settings - Fork 0
Use production build for make up #262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
…d in client.go currently
…duction-build-for-make-up
…duction-build-for-make-up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@micheal-parks I wrote this before your round-trip changes, so I'd appreciate a thorough check of this to make sure I didn't break anything when resolving conflicts. No rush.
Co-authored-by: Micheal Parks <[email protected]>
Engineers running make up to test locally were hitting dev-mode issues: stale HMR cache, outdated deps, dev artifacts interfering with testing.
Now, we assume
make upis NOT used for local development.motion-toolsengineers should just continue to usepnpm devfor development.make upnow builds and serves the app as static files. We run two bun servers:The ports are now fully configurable via the
WS_PORTandSTATIC_PORTenvironment variables, but we use the above as default fallbacks.When running
make up, we skip the standard production build and use a hash-based change-detection system. It rebuilds only when source files change.