test(rsc): fix setupIsolatedFixture in ecosystem CI - #1471
Merged
Merged
Conversation
Copy the repository package manager and allowed build dependencies into isolated fixtures so their installs behave consistently in ecosystem CI. Co-authored-by: Codex (GPT-5) <noreply@openai.com>
Co-authored-by: Codex (GPT-5) <noreply@openai.com>
Co-authored-by: Codex (GPT-5) <noreply@openai.com>
Co-authored-by: Codex (GPT-5) <noreply@openai.com>
Co-authored-by: Codex (GPT-5) <noreply@openai.com>
Co-authored-by: Codex (GPT-5) <noreply@openai.com>
Co-authored-by: Codex (GPT-5) <noreply@openai.com>
Co-authored-by: Codex (GPT-5) <noreply@openai.com>
Co-authored-by: Codex (GPT-5) <noreply@openai.com>
Co-authored-by: Codex (GPT-5) <noreply@openai.com>
Co-authored-by: Codex (GPT-5) <noreply@openai.com>
Co-authored-by: Codex (GPT-5) <noreply@openai.com>
hi-ogawa
marked this pull request as ready for review
September 25, 2026 02:32
hi-ogawa
changed the title
hi-ogawa
changed the title
hi-ogawa
changed the title
setupIsolatedFixture in ecosystem CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RSC isolated fixtures are installed outside the repository workspace, so they lose the root pnpm settings. In ecosystem CI, this selects the fixture package manager and rejects the ignored esbuild and workerd build scripts.
This PR copies the root packageManager and onlyBuiltDependencies into each generated isolated fixture so its install behaves like the repository install. The targeted ecosystem run passes: https://github.com/vitejs/vite-ecosystem-ci/actions/runs/36084885957