Skip to content

test: don't skip unicode related tests anymore#16339

Merged
bluwy merged 6 commits intovitejs:mainfrom
sapphi-red:test/dont-skip-unicode-tests-anymore
May 7, 2024
Merged

test: don't skip unicode related tests anymore#16339
bluwy merged 6 commits intovitejs:mainfrom
sapphi-red:test/dont-skip-unicode-tests-anymore

Conversation

@sapphi-red
Copy link
Copy Markdown
Member

Description

This PR reverts #15096 as the bug (nodejs/node#48673) was fixed in node 20.12.0.

@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sapphi-red sapphi-red marked this pull request as ready for review April 14, 2024 10:33
@sapphi-red sapphi-red added p1-chore Doesn't change code behavior (priority) test labels Apr 14, 2024
@sapphi-red
Copy link
Copy Markdown
Member Author

Given that more than 1 month has passed since the 20.12.0 release, I think we can now merge this PR.

@sapphi-red sapphi-red requested review from bluwy and patak-cat May 7, 2024 06:08
@bluwy bluwy merged commit c2a4ce5 into vitejs:main May 7, 2024
@sapphi-red sapphi-red deleted the test/dont-skip-unicode-tests-anymore branch May 7, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p1-chore Doesn't change code behavior (priority) test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants