fix: BaseBone.clone_value should just copy
#1558
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phorward
added
the
bug(fix)
ArneGudermann
approved these changes
Sep 2, 2025
phorward
added
the
Priority: High
sveneberth
requested changes
Sep 2, 2025
| def clone_value(self, skel: "SkeletonInstance", src_skel: "SkeletonInstance", bone_name: str) -> None: | ||
| """Clone / Set the value for this bone depending on :attr:`clone_behavior`""" | ||
| match self.clone_behavior.strategy: | ||
| case CloneStrategy.COPY_VALUE: |
Member
There was a problem hiding this comment.
Not tested, but I think this should fix it (before the old code):
Suggested change
| case CloneStrategy.COPY_VALUE: | |
| case CloneStrategy.COPY_VALUE: | |
| _ = skel[boneName] # ensure the bone is being unserialized first |
| skel.renderAccessedValues[bone_name] = copy.deepcopy(src_skel.renderAccessedValues[bone_name]) | ||
| except KeyError: | ||
| pass # bone_name is not in renderAccessedValues, cannot clone it | ||
| skel[bone_name] = copy.deepcopy(src_skel[bone_name]) |
Member
There was a problem hiding this comment.
This will fail if renderPreparation is enabled. That's why I implemented it low-level.
The problem, which is probably also responsible for yours, is that the value/entity was not unserialized and is not loaded into the access values, so you are copying something that is not there.
phorward
added
viur-meeting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just found out that the List.clone-prototype function does not copy values correctly.
It was strange, but this simply fixed it, I think it has to do with the intermixing of accessedValues, renderAccessedValues and dbEntity.
This mess must be entirely cleaned up.