refactor: PasswordBone with explicit "doublecheck"-type and explicit tests
#1562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a more explicit variant of the PasswordBone with minimum default. This makes the PasswordBone what is in its simplest form: A field to enter a password. For password strength tests, additional threshold and tests can be specified explicitly. The client-side must: - Accept a bone type "password" with or without tests. When tests are given, they must be met. - Accept a bone type "password.doublecheck" with two input fields to prompt the password twice AND prove specific tests, if given.
phorward
force-pushed
the
refactor-friedensangebot
branch
from
3603b56 to
1275704
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a more explicit variant of the PasswordBone with minimum default.
This makes the PasswordBone what is in its simplest form: A field to enter a password. For password strength tests, additional threshold and tests can be specified explicitly.
The client-side must: