Skip to content

Fix sort tests "test_numeric" and "test_numeric_reverse" #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JalonSolov merged 1 commit into from
Dec 23, 2025
Merged

Fix sort tests "test_numeric" and "test_numeric_reverse" #191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/sort/sort.v
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,10 +136,9 @@ fn sort_general_numeric(mut lines []string, options Options) {
const minus_infinity = f64(-0xFFFFFFFFFFFFFFF)

fn numeric_rest(s string) (f64, string) {
mut num := 0.0
mut rest := s
mut allow_blanks := true
mut allow_sign := true
mut end := s.len
for i := 0; i < s.len; i++ {
c := s[i]
if allow_blanks && c == space {
Expand All @@ -155,9 +154,12 @@ fn numeric_rest(s string) (f64, string) {
allow_blanks = false
continue
}
num = strconv.atof64(s[0..i]) or { minus_infinity }
rest = s[i..].clone()
// non-numeric char found
end = i
break
}
num := strconv.atof64(s[0..end]) or { minus_infinity }
rest := s[end..]
return num, rest
}

Expand Down
Loading