string: speed up, fix and test impl_utf8_to_utf32 #26109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@spytheman CI fails seems to be not related. What do you think? |
spytheman
reviewed
Dec 25, 2025
spytheman
reviewed
Dec 25, 2025
spytheman
approved these changes
Dec 25, 2025
Member
spytheman
left a comment
spytheman
left a comment
There was a problem hiding this comment.
Excellent work.
Can you please just tweak the tests, to use a string representation of the original where possible, followed by .bytes()?
It makes it a lot more obvious, whether the test is correct or not, which in turn makes maintenance easier.
Member
|
(and yes, the CI failure seems unrelated to this change) |
Co-authored-by: Delyan Angelov <[email protected]>
Co-authored-by: Delyan Angelov <[email protected]>
…est/impl_utf8_to_utf32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.