Skip to content

Use CBLAS for double precision vector norm - #418

Merged
ulises-jeremias merged 1 commit into
mainfrom
perf/cblas-dnrm2
Oct 7, 2026
Merged

ulises-jeremias merged 1 commit into
mainfrom
perf/cblas-dnrm2

Conversation

@ulises-jeremias

Copy link
Copy Markdown
Member

Summary

  • Dispatch valid double precision vector norm calls to the configured CBLAS backend.
  • Keep pure V fallback behavior for invalid strides and undersized inputs.
  • Add coverage for strided inputs and extreme magnitudes.

Validation

  • Pure V BLAS tests pass.
  • CBLAS tagged module check passes.
  • Linked CBLAS smoke test passes using the system CBLAS library.
  • Formatting and diff checks pass.

@ulises-jeremias
ulises-jeremias merged commit 94f3e29 into main Oct 7, 2026
2 of 12 checks passed
@coderabbitai

coderabbitai Bot commented Oct 7, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: cb1f9bc5-5973-4391-bc3c-8122cdfc3ad3
📥 Commits

Reviewing files that changed from the base of the PR and between ecf13b6 and 499a0e0.

📒 Files selected for processing (2)
  • blas/blas_test.v
  • blas/oblas_d_vsl_blas_cblas.v
 _____________________________________________________
< Merge conflicts fear my conflict-resolution skills. >
 -----------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant