Skip to content

Validate matrix storage before CBLAS dispatch - #419

Merged
ulises-jeremias merged 1 commit into
mainfrom
fix/cblas-sgemm-validation
Oct 7, 2026
Merged

ulises-jeremias merged 1 commit into
mainfrom
fix/cblas-sgemm-validation

Conversation

@ulises-jeremias

Copy link
Copy Markdown
Member

Summary

  • Validate output and input dimensions, leading strides, and storage lengths before the CBLAS sgemm call.
  • Delegate invalid inputs to the existing pure V implementation so its documented panics and edge semantics remain consistent.

Validation

  • Pure V BLAS tests pass.
  • CBLAS-tagged BLAS tests pass using the system CBLAS library.
  • CBLAS-tagged shared module check passes.
  • Formatting and diff checks pass.

@ulises-jeremias
ulises-jeremias merged commit a00af30 into main Oct 7, 2026
3 of 12 checks passed
@coderabbitai

coderabbitai Bot commented Oct 7, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d1e671d3-8f6b-44b4-ba88-bafaa385ece2
📥 Commits

Reviewing files that changed from the base of the PR and between 94f3e29 and 9304197.

📒 Files selected for processing (1)
  • blas/oblas_d_vsl_blas_cblas.v
 ___________________________________________________________________________________
< The best way to predict the future is to implement it. - David Heinemeier Hansson >
 -----------------------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant