-
Notifications
You must be signed in to change notification settings - Fork 45
Add autorun_on_main into CI pipeline #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
b91871e to
596498b
Compare
596498b to
b9ef84b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this only on CI? (I'm asking because I saw you listed a fastcheck build in description, but the change is made to just test-template-ci.j2). Fastcheck currently only runs a set of 4-5 tests.
Instead of autorun_on_ready, can we name it something else like always_run or ci_always_run and add a description for it in the list of args in https://github.com/vllm-project/vllm/blob/main/.buildkite/test-pipeline.yaml#L8? We are currently associating ready label with launching CI, but that might change in the future.
|
Thanks @khluu !
I want to make it only for CI not fastcheck - I used fastcheck pipeline to simulate the scenarios where ready label is not being applied, and ci pipeline when ready is being applied. Let me know if this is wrong!
Sure, I can rename it! and add the doc into test-pipeline.yaml together with this PR |
b9ef84b to
bfe17f7
Compare
|
Thanks @hl475 ! Let's merge the PR to add the field on vllm repo first, then we can merge this one. |
bfe17f7 to
2cce0b3
Compare
Signed-off-by: Kevin H. Luu <[email protected]>
2cce0b3 to
39f57ae
Compare
|
Hi @khluu , per today's CI meeting discussion, I repurposed this PR a bit by introducing I need to update the corresponding PR on vLLM side, but want to get some of your thoughts on this. Thanks! |
The goal of this PR is to add a new feature - if a test/label has
autorun_on_mainas True AND the PR has been merged (so running on main branch)if a test/label has, then the corresponding test/label will run automatically (so no need to manually click to unblock).ci_always_runas True AND the PR has been marked as readyThe hope of the feature is adding some selected tests/labels to run automatically on PR to maintain trunk health.
Some alternatives could be (1) merge queue, (2) new symbol other than ready. I am open to alternative, but it could change user experience a bit.Previously we came up with ci_always_run, but it will run per rebase once ready, which might still be expensive.