Skip to content

Conversation

@hl475
Copy link
Collaborator

@hl475 hl475 commented Oct 30, 2025

The goal of this PR is to add a new feature - if a test/label has autorun_on_main as True AND the PR has been merged (so running on main branch)if a test/label has ci_always_run as True AND the PR has been marked as ready, then the corresponding test/label will run automatically (so no need to manually click to unblock).

The hope of the feature is adding some selected tests/labels to run automatically on PR to maintain trunk health. Some alternatives could be (1) merge queue, (2) new symbol other than ready. I am open to alternative, but it could change user experience a bit. Previously we came up with ci_always_run, but it will run per rebase once ready, which might still be expensive.

@yeqcharlotte yeqcharlotte requested a review from khluu October 30, 2025 21:41
@hl475 hl475 changed the title [WIP] autorun_on_ready [WIP] Add autorun_on_ready into CI pipeline Oct 31, 2025
@hl475 hl475 changed the title [WIP] Add autorun_on_ready into CI pipeline Add autorun_on_ready into CI pipeline Oct 31, 2025
Copy link
Collaborator

@khluu khluu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this only on CI? (I'm asking because I saw you listed a fastcheck build in description, but the change is made to just test-template-ci.j2). Fastcheck currently only runs a set of 4-5 tests.

Instead of autorun_on_ready, can we name it something else like always_run or ci_always_run and add a description for it in the list of args in https://github.com/vllm-project/vllm/blob/main/.buildkite/test-pipeline.yaml#L8? We are currently associating ready label with launching CI, but that might change in the future.

@hl475
Copy link
Collaborator Author

hl475 commented Oct 31, 2025

Thanks @khluu !

Is this only on CI? (I'm asking because I saw you listed a fastcheck build in description, but the change is made to just test-template-ci.j2). Fastcheck currently only runs a set of 4-5 tests.

I want to make it only for CI not fastcheck - I used fastcheck pipeline to simulate the scenarios where ready label is not being applied, and ci pipeline when ready is being applied. Let me know if this is wrong!

Instead of autorun_on_ready, can we name it something else like always_run or ci_always_run and add a description for it in the list of args in https://github.com/vllm-project/vllm/blob/main/.buildkite/test-pipeline.yaml#L8?

Sure, I can rename it! and add the doc into test-pipeline.yaml together with this PR

@hl475 hl475 changed the title Add autorun_on_ready into CI pipeline Add ci_always_run into CI pipeline Oct 31, 2025
@hl475 hl475 requested a review from khluu October 31, 2025 18:02
@khluu
Copy link
Collaborator

khluu commented Oct 31, 2025

Thanks @hl475 ! Let's merge the PR to add the field on vllm repo first, then we can merge this one.

@hl475 hl475 changed the title Add ci_always_run into CI pipeline Add autorun_on_main into CI pipeline Nov 5, 2025
@hl475
Copy link
Collaborator Author

hl475 commented Nov 5, 2025

Hi @khluu , per today's CI meeting discussion, I repurposed this PR a bit by introducing autorun_on_main instead of ci_always_run - the test will run automatically once merged into main branch.

I need to update the corresponding PR on vLLM side, but want to get some of your thoughts on this. Thanks!

@hl475 hl475 requested a review from khluu November 5, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants