feat: Support a list of concurrencies for bench configs - #58
Merged
Conversation
Signed-off-by: Micah Williamson <micah.williamson@amd.com>
Signed-off-by: Micah Williamson <micah.williamson@amd.com>
Signed-off-by: Micah Williamson <micah.williamson@amd.com>
…cy-list Signed-off-by: Micah Williamson <micah.williamson@amd.com>
Signed-off-by: Micah Williamson <micah.williamson@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows us to specify a list of concurrencies for bench configs in workloads. For example:
The above would run a an 8k/1k benchmark for each concurrency listed (1, 64, 128). You can also optionally change
num_promptsto a list to correspond to each max_concurrency, e.g.:In
expand_bench_config,-conc-<value>is appended to each config'snamefor each conc, so in the above example the final names for the config would be8k-in-1k-out-conc-1,8k-in-1k-out-conc-64,8k-in-1k-out-conc-128.I've updated
workloads/qwen3_5_mi355x.yamlas an initial example.