Skip to content

Conversation

@xingliu14
Copy link
Collaborator

@xingliu14 xingliu14 commented Nov 12, 2025

Description

Add unit tests for envs.py.
Addressing #1016.

cc @kyuyeunk @QiliangCui

Tests

pytest tests/test_envs.py -v

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

@kyuyeunk
Copy link
Collaborator

@QiliangCui can you take a look and see if the test looks good?

- Remove trailing whitespace
- Fix yapf formatting for line wrapping

Signed-off-by: Xing Liu <[email protected]>
xingliu14 added a commit to xingliu14/tpu-inference that referenced this pull request Nov 14, 2025
@kyuyeunk kyuyeunk merged commit f139996 into vllm-project:main Nov 14, 2025
3 checks passed
@xingliu14 xingliu14 deleted the env_var branch November 14, 2025 06:12
AahilA pushed a commit to amishacorns/tpu-inference that referenced this pull request Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants