-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
[CI] Add non-eager test-case for SharedStorageConnector #28544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: NickLucche <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request introduces a non-eager test case for SharedStorageConnector by refactoring the existing test structure. The use of pytest fixtures to manage test setup is a good improvement for maintainability and performance. However, I've identified a critical issue with a session-scoped fixture that could lead to test flakiness due to state leakage. Additionally, I've suggested a refactoring to eliminate code duplication between the newly introduced test functions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
|
Currently leading to OOM : |
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
I realized when we merged this fix #28253 we haven't actually added a test case to our suite (the referred issue required manual edits, hence it's not really tracked in CI).
This PR adds a test-case for that.