Skip to content

Conversation

@NickLucche
Copy link
Collaborator

I realized when we merged this fix #28253 we haven't actually added a test case to our suite (the referred issue required manual edits, hence it's not really tracked in CI).
This PR adds a test-case for that.

Signed-off-by: NickLucche <[email protected]>
@NickLucche NickLucche requested a review from ApostaC as a code owner November 12, 2025 10:28
@NickLucche NickLucche added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 12, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request introduces a non-eager test case for SharedStorageConnector by refactoring the existing test structure. The use of pytest fixtures to manage test setup is a good improvement for maintainability and performance. However, I've identified a critical issue with a session-scoped fixture that could lead to test flakiness due to state leakage. Additionally, I've suggested a refactoring to eliminate code duplication between the newly introduced test functions.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
@NickLucche
Copy link
Collaborator Author

Currently leading to OOM : torch.OutOfMemoryError: CUDA out of memory, will play around with test config

Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kv-connector ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants