Update xformers to 0.0.32.post2 instead of dev commit #28551
Conversation
We were installing a non-released version of xformers for CUDA: 0.0.33+5d4b92a5.d20251029 5d4b92a5 is actually the commit for 0.0.32.post2 tag, so this PR just replace the version so it's cleaner and we now consumed a stable tag (which by the way is the latest). Signed-off-by: Emilien Macchi <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the xformers dependency from a development version to the stable 0.0.32.post2 tag. This is a good practice as it improves dependency stability and reproducibility. Based on the description, the commit hash used for the previous development version corresponds to this new stable tag, so this change should be functionally equivalent and is primarily for clarity and correctness in dependency management. The change is sound and I have no issues to report.
NickLucche
left a comment
NickLucche
left a comment
There was a problem hiding this comment.
I think the plan it's actually to get rid of xformers cc @ywang96.
I stil couldn't find a torch2.9 built wheel with this PR (though I suppose this wasn't the intent):
VLLM_USE_PRECOMPILED=1 uv pip install -e .
× No solution found when resolving dependencies:
╰─▶ Because xformers==0.0.32.post2 depends on torch==2.8.0 and vllm==0.11.1rc7.dev72+g074b03cb5.precompiled depends on torch==2.9.0, we..
|
I thought we still have to have a torch 2.9 compatible wheel at least for the release - what is the status of that? |
|
https://github.com/facebookresearch/xformers/releases/tag/v0.0.33 came out, I wonder if you're going to use that in v0.11.1 or get rid of xformers at all. |
|
This version won't work because it's built with PyTorch 2.8. That's the reason why we have a custom |
|
I'll close my PR in favor of #28600 |
5 participants
Purpose
We were installing a non-released version of xformers for CUDA:
0.0.33+5d4b92a5.d20251029
5d4b92a5 is actually the commit for 0.0.32.post2 tag, so this PR just
replace the version so it's cleaner and we now consumed a stable tag
(which by the way is the latest).