Skip to content

Conversation

@hmellor
Copy link
Member

@hmellor hmellor commented Nov 12, 2025

Should make this job green in nightly CI

@mergify mergify bot added the multi-modality Related to multi-modality (#4194) label Nov 12, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request skips a test that is currently broken due to an issue in the transformers library. This is a good temporary solution to fix the CI. However, to ensure this test is re-enabled in the future, I've suggested adding a TODO comment with a link to a tracking issue. This will help maintain test coverage in the long run.

Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 12, 2025 15:46
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 12, 2025
@hmellor hmellor disabled auto-merge November 12, 2025 19:37
@hmellor hmellor merged commit a39dd7b into vllm-project:main Nov 12, 2025
20 checks passed
@hmellor hmellor deleted the skip-mm-test branch November 12, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

multi-modality Related to multi-modality (#4194) ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants