Add default proxied network isolation for registry benchmarks#96
Draft
jdx wants to merge 2 commits intovltpkg:mainfrom
Draft
Add default proxied network isolation for registry benchmarks#96jdx wants to merge 2 commits intovltpkg:mainfrom
jdx wants to merge 2 commits intovltpkg:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
registry-*benchmark runs default to a local toxiproxy-backed network path with a symmetric bandwidth cap, while keeping--network-profile=noneas an escape hatch./bench, document the behavior, and install/configure toxiproxy in setup and workflow paths so the default behavior is runnable in CIVerification
bash -n benchbash -n scripts/network-isolation.shbash -n scripts/registry/common.shbash -n scripts/setup.sh./bench run --variation=registry-clean --fixtures=next --registries=vlt --dry-run