Add proper dalitz decays #41
Conversation
Add dalitz decays with VDM decay form factors for pi0 -> gamma e+e- eta -> gamma e+e- omega -> pi0 e+e-
|
I recommend @pzhristov as reviewer since some time ago @MohammadAlTurany discussed the proposed changes with him. |
|
is there any chance that the PR can be merged rather soon. There is a new FirSoft release in the pipeline and we have to know if we can use Geant3 from upstream or if we have to maintain our own fork. Best regards Florian |
|
@fuhlig1 Would it be possible to put the references to the form-factor calculations? This will help to review the changes. |
Hi @fuhlig, Thank you for reminder, I was waiting for @pzhristov review. Can you, please, address Peter's comment? When done, we can merge in master with no delay. Best regards, Ivana |
|
I have few other comments I will post today. |
| C | ||
| vdmform = 0.0 | ||
| if (x.ge.rmas) return | ||
| if (x.lt.2.0*0.511) return |
There was a problem hiding this comment.
I propose to use parameter for the electron mass (0.511).
| @@ -0,0 +1,161 @@ | |||
| c------------------------------------------------------------------------------ | |||
| real function vdmform(x,rmas,isw) ! VDM formfactor | |||
There was a problem hiding this comment.
Please add description of the function arguments. It is also helpful to add reference to the paper where the form-factors are taken from.
| dalit = ((1.-(x/rmas)**2)**3/(x/rmas))*1./(1.-(x/rhom)**2)**2 | ||
| vdmform = 8.2e-4*dalit*f | ||
| else if (isw.eq.2) then ! vector meson -> pi0 e+ e- | ||
| delta = (135.0/rmas)**2 |
There was a problem hiding this comment.
Please use parameter for the pi0 mass (135.0)
| end | ||
| c------------------------------------------------------------------------------ | ||
| real function qedform(x,rmas,isw) ! QED formfactor | ||
| real*4 x, rmas, dalit ! masses in MeV |
There was a problem hiding this comment.
Please add description of the function arguments. It is also helpful to add reference to the paper where the form-factors are taken from.
| qedform = 0.0 | ||
| if (x.ge.rmas) return | ||
| if (x.lt.2.0*0.511) return | ||
|
|
There was a problem hiding this comment.
Please use parameter for the electron mass (0.511)
| qedform = 8.2e-4*dalit*f | ||
| else if (isw.eq.2) then ! vector meson | ||
| delta = (135.0/rmas)**2 | ||
| bracket = (1.+(x/rmas)**2/(1.-delta))**2 |
There was a problem hiding this comment.
Please use parameter for the pi0 mass.
| real xmin(3), xmax(3), wmax(3), mesonmass(3), rndm(2) | ||
| integer isw(3) | ||
| data mesonmass/134.9766,547.75,782.59/ | ||
| data isw/1,1,2/ |
There was a problem hiding this comment.
Is isw really /1,1,2/? Does it mean omega is discarded from the simulation?
| c------------------------------------------------------------------------------ | ||
|
|
||
| SUBROUTINE GDALET(XM0,XM1,XM2,XM3,PCM,IDH) | ||
| C. |
There was a problem hiding this comment.
Where does this function come from? It is good to add a comment to the description below.
|
thanks for the comments and the extensive check. I will try to address the comments next week. |
|
Hi @fuhlig1 , This is a reminder that this PR waits for your update. Cheers, Ivana |
|
Thanks for the reminder and sorry for the delay but it took some time to find the reference. |
3 participants
Add dalitz decays with VDM decay form factors for
pi0 -> gamma e+e-
eta -> gamma e+e-
omega -> pi0 e+e-