Repository navigation
fix: harden change notifications and remove unrelated docs - #40
Merged
Merged
Conversation
Retry failed notification acknowledgements without redisplaying toasts, discard responses from a previous location, and stop inspection after disposal. Remove the OMO-slim guide, duplicate inspection DTO and JSON round trips. Add regression coverage for the notification and lifecycle failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review of #39 found two reproducible notification failures: failed acknowledgement writes were never retried, and a delayed RPC response could show a toast after the active project changed. It also allowed inspection to keep reading after plugin disposal.
The two notification regression tests fail against the previous implementation and pass with these fixes. All 163 tests, lint, typecheck, build, and offline package/release checks pass locally. CI also covers Node 22/24 and real OpenCode 2.0.16/2.0.24.
No new dependencies, configuration options, selection strategies, or runtime integrations.