Repository navigation
feat: explain alias resolution decisions - #47
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When a floating alias resolves unexpectedly, the current inspection view only shows the target. Users need to see which candidates were excluded and why the winner was selected.
Changes
/model-aliases explain <provider/alias>and a structuredexplainRPC method.Review and validation
Applied iterative implementation, defect review and simplification (ponytail). Removed an unnecessary candidate lookup map and kept the implementation in the existing resolver/RPC/TUI flow, without dependencies, strategy frameworks or persistent explanation storage.
pnpm run verify: passed; 177 tests, lint, typecheck and build.smoke:inspectwith OpenCode 2.0.22: passed, including the new explain RPC, history across restarts and zero provider requests.The existing config-disabled model limitation (#42) remains documented. If strict setup fails, the plugin RPC is unavailable as before.
Follow-up defect review
Added regression tests that failed against the original PR and fixed:
Reused the existing object validator and kept the fixes in the current pipeline. No new dependencies or architectural layers.
Validation after fixes:
pnpm run verify(177 passing tests) and packed-product inspection/explanation smoke with OpenCode 2.0.22 (zero provider requests). The original CI passed; the updated commit reruns the same matrix.Closes #24