Repository navigation
perf(core): scan up to 3x faster with workers that share memory - #281
Merged
Merged
Conversation
…y in worker services
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was an improvement I’d been wanting to make for a long time.
One of the main bottlenecks in scan performance was that each directory was reported to the coordinator by each of the workers, followed by a return message to send them new work. This consumed approximately 90 per cent of resources.
With this change, the workers now share a memory space which they use themselves to submit and collect tasks.
The measured improvement is between 40% and 70%.