Repository navigation
ci: cap job runtimes and reduce Node downloads - #3258
Merged
Merged
Conversation
Contributor
CLI artifact sizes (
|
| Artifact | Format | Base | PR | Change |
|---|---|---|---|---|
packages/cli/dist |
Directory total | 2.26 MiB | 2.26 MiB | 0 B (0.00%) |
packages/core/dist |
Directory total | 4.07 MiB | 4.07 MiB | 0 B (0.00%) |
| Combined package dist | Directory total | 6.33 MiB | 6.33 MiB | 0 B (0.00%) |
vp (Linux x64) |
Binary | 8.26 MiB | 8.26 MiB | +48 B (+0.00%) |
vp (Linux x64) |
gzip -9 | 3.77 MiB | 3.77 MiB | +657 B (+0.02%) |
| NAPI (Linux x64) | Binary | 35.51 MiB | 35.51 MiB | 0 B (0.00%) |
| NAPI (Linux x64) | gzip -9 | 14.14 MiB | 14.14 MiB | 0 B (0.00%) |
vp (macOS ARM64) |
Binary | 5.39 MiB | 5.39 MiB | 0 B (0.00%) |
vp (macOS ARM64) |
gzip -9 | 3.21 MiB | 3.21 MiB | +173 B (+0.01%) |
| NAPI (macOS ARM64) | Binary | 42.23 MiB | 42.28 MiB | +48.38 KiB (+0.11%) |
| NAPI (macOS ARM64) | gzip -9 | 18.27 MiB | 18.28 MiB | +7.19 KiB (+0.04%) |
vp (Windows x64) |
Binary | 6.11 MiB | 6.11 MiB | +1.50 KiB (+0.02%) |
vp (Windows x64) |
gzip -9 | 2.83 MiB | 2.83 MiB | +703 B (+0.02%) |
| NAPI (Windows x64) | Binary | 31.53 MiB | 31.53 MiB | 0 B (0.00%) |
| NAPI (Windows x64) | gzip -9 | 12.84 MiB | 12.84 MiB | -2 B (-0.00%) |
| Trampoline (Windows x64) | Binary | 13.50 KiB | 13.50 KiB | 0 B (0.00%) |
| Trampoline (Windows x64) | gzip -9 | 7.09 KiB | 7.09 KiB | +1 B (+0.01%) |
| Installer (Windows x64) | Binary | 4.67 MiB | 4.67 MiB | +512 B (+0.01%) |
| Installer (Windows x64) | gzip -9 | 2.24 MiB | 2.24 MiB | +355 B (+0.02%) |
fengmk2
changed the title
fengmk2
changed the title
fengmk2
changed the title
fengmk2
marked this pull request as ready for review
October 28, 2026 09:51
Brooooooklyn
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some CI jobs ran for over an hour, and snapshot jobs stalled while preparing Node.js. Main CI jobs get a
20-minute limit, except the existing30-minute limit forcertless-image-test. Binary-size builds get30minutes; their helper jobs get10minutes.Use
20.20.2,22.23.4,24.22.1, and26.12.1in snapshot fixtures, with older pins for loader and migration boundaries. Prepare these runtimes before snapshot command timers start, using one version list for Unix and Windows. Keep empty-cache installation coverage.Share installed runtimes across Rust integration tests while keeping project files isolated. Run the explicit-version test outside the repository so it does not install the repository's pnpm version.
Read
VP_NODE_DIST_MIRRORfrom repository Actions variables across Rust, snapshot, CLI, installer, ecosystem, and Docker tests. Pass it into isolated snapshot commands, Docker builds, and test containers. Fixture overrides still take precedence. Usehttps://nodejs.org/distwhen the repository variable is empty or unset. Musl jobs keephttps://unofficial-builds.nodejs.org/download/releasefor compatible archives.Enable
VP_LOG=vp_js_runtime=infoduring runtime preparation to report download stages, retries, and archive sizes. Use trace timestamps to identify slow stages. Report total preparation time for each Node version on Unix and Windows.Set the generator template smoke test limit to
35seconds to allow slow CI startup. Keep the subprocess limit at30seconds and report subprocess errors.A broken
create-viterelease returned success without generating project files. Fail installer checks when scaffolding produces nopackage.jsonor the build fails, including Alpine and Windows shells. Load the generated shell environment in Alpine sovp env doctorsees both shim directories.The Docker browser fixture pins Vitest
4, which conflicts with the bundled Vitest5runner. Migrate the fixture with the installed toolchain before checking its lockfile and running Chromium.