Skip to content

feat(examples): add Chroma + OpenViking minimal integration example#1561

Open
yeyitech wants to merge 1 commit intovolcengine:mainfrom
yeyitech:feat/rfc1190-chroma-minimal-example
Open

feat(examples): add Chroma + OpenViking minimal integration example#1561
yeyitech wants to merge 1 commit intovolcengine:mainfrom
yeyitech:feat/rfc1190-chroma-minimal-example

Conversation

@yeyitech
Copy link
Copy Markdown
Contributor

Summary

  • add a minimal Chroma + OpenViking integration example with short-context and long-memory flows
  • include sample docs, local requirements, and example ov.conf
  • add a small smoke test for fixture/document loading

Testing

  • python -m pytest -q examples/chroma-openviking/test_smoke.py

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Codex seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🏅 Score: 85
🧪 PR contains tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ Recommended focus areas for review

Silent Exception Swallowing

The bare except Exception: block when deleting the Chroma collection swallows all errors without logging, hiding potential issues like permission errors or invalid client state.

try:
    client.delete_collection(collection_name)
except Exception:
    pass

@github-actions
Copy link
Copy Markdown

PR Code Suggestions ✨

No code suggestions found for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

2 participants