Repository navigation
fix(langchain): preserve Unicode archive query constraints - #7040
Merged
ZaynJarvis merged 1 commit intoNov 6, 2026
Merged
Conversation
This was referenced Nov 4, 2026
(cherry picked from commit 4197176)
ehz0ah
force-pushed
the
consolidate/langchain-archive-20261104
branch
from
November 6, 2026 05:37
e20f9fc to
388a4dc
Compare
ehz0ah
marked this pull request as ready for review
November 6, 2026 06:28
12 of 21 tasks
donghao95
added a commit
to donghao95/OpenViking
that referenced
this pull request
Nov 6, 2026
* fix(langchain): preserve Store persistence and discovery contracts (volcengine#7038) * fix(langchain): resolve framework relocation conflicts Merge upstream main while preserving both separator-key regressions and upstream mapping-value tests. Use the relocated package in the boundary check. Validation: 404 tests passed, 1 skipped (optional SQLite checkpointer unavailable); Ruff, mypy, build and twine checks passed. (cherry picked from commit a5752a0) * fix(langchain): propagate Store directory listing failures (cherry picked from commit dac457e) * fix(langchain): skip projection for empty Store index fields (cherry picked from commit 50b5286) * fix(langchain): preserve Store index write failures (cherry picked from commit 20a4da1) * test(langchain): assert stable async Store timeout errors Signed-off-by: Hao Zhe <haozhe4547@gmail.com> * docs(langchain): note propagated Store discovery errors Signed-off-by: Hao Zhe <haozhe4547@gmail.com> --------- Signed-off-by: Hao Zhe <haozhe4547@gmail.com> Co-authored-by: codesheepchen <chenjiaxun2@163.com> Co-authored-by: ydflow <314143294+ydflow@users.noreply.github.com> Co-authored-by: stefanielizeth73-art <stefanielizeth73@gmail.com> * fix(langchain): preserve Unicode archive query terms (volcengine#7040) (cherry picked from commit 4197176) Co-authored-by: ktz03 <2484593937@qq.com> * feat(langchain): preserve owned-client authentication and Store cleanup (volcengine#7039) * feat(langchain): forward explicit SDK authentication mode (cherry picked from commit 1c8d25e) * fix(langchain): drain Store-owned requests during shutdown Signed-off-by: Hao Zhe <haozhe4547@gmail.com> * fix(langchain): reject reentrant Store shutdown Signed-off-by: Hao Zhe <haozhe4547@gmail.com> --------- Signed-off-by: Hao Zhe <haozhe4547@gmail.com> Co-authored-by: Xinmin Zeng <135568692+fancyboi999@users.noreply.github.com> --------- Signed-off-by: Hao Zhe <haozhe4547@gmail.com> Co-authored-by: z1gon <130889443+ehz0ah@users.noreply.github.com> Co-authored-by: codesheepchen <chenjiaxun2@163.com> Co-authored-by: ydflow <314143294+ydflow@users.noreply.github.com> Co-authored-by: stefanielizeth73-art <stefanielizeth73@gmail.com> Co-authored-by: ktz03 <2484593937@qq.com> Co-authored-by: Xinmin Zeng <135568692+fancyboi999@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Archive search drops Chinese terms and truncates accented words through ASCII-only tokenization. Reuse the shared Unicode-aware token extraction for explicit archive payload filtering, history grep and context fallback.
An archive containing 部署在月球。café notes. no longer matches absent terms such as 火星 or cafè. Existing short-ASCII filtering and literal C++ raw-history matching remain unchanged.
Unicode normalization and broader case equivalence are separate matching requirements. This PR retains the existing token/grep behavior and original text offsets. Empty-token archive/context filtering is also separate from literal raw-history matching.
Cherry-picks #5770 into the current package paths with the original author, date and source SHA retained.
Fixes #5769.
Validation against upstream dfb9eb8: 841 passed on Python 3.12/current frameworks; 839 passed with 2 expected skips on Python 3.10/framework 1.0.0. The combined candidate passes 923 tests on Python 3.12 and 921 with 2 expected skips on Python 3.10/framework 1.0.0. Ruff lint/format, mypy, diff checks, wheel/sdist builds and Twine pass for all three branches and the combined candidate. All 16 runtime files in each distribution match its Git head. A clean installation of the combined wheel with published SDK 0.1.18 passes 918 adapter tests, retrieval and LangGraph agent smoke checks, and dependency checks.
Companion drafts: #7038 (Store contracts) and #7039 (owned clients). This branch is independent of both and has been validated in the combined candidate.
Contributor: ktz03. Hao Zhe is the cherry-pick committer.
Landing: preserve the original commits through merge/rebase merging. If squashing is required, retain contributor credit explicitly. Mark the original proposals covered after the accepted consolidated change lands.
Human Involvement
Type of Change
Checklist